1243260: Make proxy config dialog work. #1236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The behaviour of widget.get_names() isn't neccasarily the same name used for the widget/object 'id' in the ui builder xml. And with Gtk.Builder, it usually is not. The proxy dialog init would try to set the state of the dialog based on the widget names, but would fail because of above mentioned change. So the state of the buttons is incorrect. To fix it, widgets.SubManBaseWidget's pull_widget() method was changed to set the expected widget name, as well as to elevate the widget name to the objects attributes.
|
ack |
wottop
added a commit
that referenced
this pull request
Jul 30, 2015
…fixes 1243260: Make proxy config dialog work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behaviour of widget.get_names() isn't neccasarily
the same name used for the widget/object 'id' in the
ui builder xml. And with Gtk.Builder, it usually
is not.
The proxy dialog init would try to set the state of the
dialog based on the widget names, but would fail because
of above mentioned change. So the state of the buttons
is incorrect.
To fix it, widgets.SubManBaseWidget's pull_widget() method
was changed to set the expected widget name, as well as
to elevate the widget name to the objects attributes.