1423443: Handle IndexError during m2crypto request #1556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like this happens because the httplib code that handles socket.error expects socket.error to be in a certain state. I'm guessing this occurs when the socket.error raised is initialized with a string, rather than a code and string. Anyways, this will handle the case specially by having the m2crypto wrapper detect IndexError explicitly, and raise a socket.error. Even though there's a risk that the IndexError is raised internally for some other reason, it seems harmless to simply map any IndexError encountered in an m2crypto request to a socket.error.
kahowell
force-pushed
the
khowell/1423443
branch
from
7229583
to
7015d77
Compare
|
ack |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like this happens because the httplib code that handles
socket.error expects socket.error to be in a certain state. I'm guessing
this occurs when the socket.error raised is initialized with a string,
rather than a code and string.
Anyways, this will handle the case specially by having the m2crypto
wrapper detect IndexError explicitly, and raise a socket.error. Even
though there's a risk that the IndexError is raised internally for some
other reason, it seems harmless to simply map any IndexError encountered
in an m2crypto request to a socket.error.