1435013: Add splay to all checks done by rhsmcertd #1577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We get the seed for the random number generator from the getrandom syscall (see 'man getrandom' for more info). The intervals for heal and cert are maintained but we do not start those timers until the completion of the initial delay. In this way if many systems are started all at the same time, they will perform their cert and heal checks at slightly different times. This was done in an attempt to reduce peak load as a result restarting a large number of systems simultaneously. Add comment with link explaining why we need to generate random numbers this way Do not delay (or splay) if given the -n option Add max-splay-minutes cli option and maxSplayMinutes conf option Ensure a number of minutes larger than RAND_MAX is not used for splay Allow splay to be disabled by setting it to 0 Update default rhsm.conf and rhsmcertd man page for splay Add new rhsmcertd option to completion script.
awood
approved these changes
Apr 6, 2017
This was referenced Apr 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intervals for heal and cert are maintained but we do not start those timers until the completion of the initial delay. In this way if many systems are started all at the same time, they will perform their cert and heal checks at slightly different times. This was done in an attempt to reduce peak load as a result restarting a large number of systems simultaneously.
There is a new cli option ('-m', '--max-splay-minutes') as well as a new config value read from /etc/rhsm/rhsm.conf rhsmcertd section 'maxSplayMinutes'. By default the random offset generated for checkins is in the range [0, 600] seconds. Setting the new value (specified in minutes) will override this default to allow for more or less splay. Setting the max-splay-minutes to 0 will cause splay not to be added at all.
If the -n or --now options are used on the cli, splay is not added either.