1438869: Clear dmidecode warnings #1584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two cases where we need to clear the warnings: 1. Non-blacklisted platforms, where this change restores old behavior of logging the warnings if they are present. 2. Blacklisted platforms, where we don't even attempt to use dmidecode, even though it is imported, where this change blindly clears the warnings.
|
💵 💎 💰 🥇 |
kahowell
added a commit
that referenced
this pull request
Apr 20, 2017
Previously tried to fix with #1584, but with that fix, only some of the cases were covered. This change covers more cases by making `get_all` responsible for importing dmidecode and then making sure any warnings are cleared. In this way, dmiinfo more fully encapsulates dmidecode, not even exposing the module outside of that method (except to pass to other helper functions).
kahowell
added a commit
that referenced
this pull request
Apr 20, 2017
Previously tried to fix with #1584, but with that fix, only some of the cases were covered. This change covers more cases by making `get_all` responsible for importing dmidecode and then making sure any warnings are cleared. In this way, dmiinfo more fully encapsulates dmidecode, not even exposing the module outside of that method (except to pass to other helper functions).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two cases where we need to clear the warnings:
logging the warnings if they are present.
even though it is imported, where this change blindly clears the
warnings.