Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1574706: Create python2-subscription-manager-rhsm properly #1819

Merged
merged 1 commit into from Jun 4, 2018

Conversation

jirihnidek
Copy link
Contributor

@jirihnidek jirihnidek commented May 10, 2018

  • BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1574706
  • This RPM packaged included _certificate.so for Python3 and
    not for Python2. Thus it couldn't work :-). The package also
    included __pycache__ for Python3
  • The package contains _certificate.so for Python 2 now and
    it should not have dependency on Python 3.

* BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1574706
* This RPM packaged included _certificate.so for Python3 and
  not for Python2. Thus it couldn't work :-). The package also
  included __pycache__ for Python3
* The package contains _certificate.so for Python 2 now and
  it should not have dependency on Python 3.
@jirihnidek jirihnidek requested a review from cnsnyder May 10, 2018 15:23
Copy link
Member

@cnsnyder cnsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you!

@cnsnyder cnsnyder merged commit 8137645 into master Jun 4, 2018
@kahowell kahowell deleted the jhnidek/1574706 branch June 8, 2018 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants