Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1700039: Cockpit - Disable cancel button on register dialog action #2134

Merged
merged 1 commit into from Aug 8, 2019

Conversation

wottop
Copy link
Member

@wottop wottop commented Aug 6, 2019

No description provided.

@jirihnidek jirihnidek self-assigned this Aug 7, 2019
Copy link
Contributor

@jirihnidek jirihnidek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that it works 👍, but I would use variable action_disabled. There is comment at line 138 that is inconsistent with your change.

@@ -189,6 +189,7 @@ class DialogFooter extends React.Component {
<button
className={ cancel_style }
onClick={event => this.cancel_click(event)}
disabled={ this.state.action_in_progress?"disabled":"" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use variable action_disabled here too? Or is there any use case that would not work with this variable?

Copy link
Contributor

@jirihnidek jirihnidek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@jirihnidek jirihnidek merged commit 8e94f15 into master Aug 8, 2019
@jirihnidek jirihnidek deleted the wottop/1700039 branch August 8, 2019 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants