Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1916540: Negative proxy tests occasionally encounter the wrong except… #2509

Merged
merged 1 commit into from Apr 12, 2021
Merged

1916540: Negative proxy tests occasionally encounter the wrong except… #2509

merged 1 commit into from Apr 12, 2021

Conversation

tlhmerry9
Copy link
Contributor

…ion handling

@cnsnyder cnsnyder requested review from a team and ptoscano and removed request for a team March 17, 2021 19:01
@jirihnidek jirihnidek self-assigned this Mar 18, 2021
jirihnidek
jirihnidek requested changes Mar 18, 2021
View reviewed changes
Copy link
Contributor

@jirihnidek jirihnidek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
Thanks for the PR. I can confirm that this change fixes the problem, but it breaks some unit tests. Please fix them. There are some stylish errors.

src/subscription_manager/cache.py Outdated Show resolved Hide resolved
@tlhmerry9
Copy link
Contributor Author

Fixed the tests related to this change.

This is blocked by PR #2479. Once PR #2479 is merged with master this branch needs to be rebased to master to resolve the test errors.

@tlhmerry9 tlhmerry9 force-pushed the tmerry/ENT-3417 branch 2 times, most recently from e916cd8 to abfe2d3 Compare March 26, 2021 19:09
@tlhmerry9 tlhmerry9 requested a review from ptoscano March 30, 2021 19:09
@tlhmerry9
Copy link
Contributor Author

@candlepin-bot ok to test

@tlhmerry9
Copy link
Contributor Author

@candlepin-bot please retest this

@tlhmerry9
Copy link
Contributor Author

all requested changes have been made

@jirihnidek jirihnidek merged commit 112872d into master Apr 12, 2021
@jirihnidek jirihnidek deleted the tmerry/ENT-3417 branch April 12, 2021 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jirihnidek jirihnidek jirihnidek approved these changes

@ptoscano ptoscano Awaiting requested review from ptoscano

Assignees

@jirihnidek jirihnidek

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@tlhmerry9 @jirihnidek @ptoscano