1924126: Fix profile upload on AWS systems #2556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would like to see the result of the CI tests. |
jirihnidek
changed the title
jirihnidek
force-pushed
the
jhnidek/ent-3448
branch
3 times, most recently
from
e6048c4
to
005f9ad
Compare
jirihnidek
force-pushed
the
jhnidek/ent-3448
branch
from
c6688d5
to
861b5fc
Compare
jirihnidek
force-pushed
the
jhnidek/ent-3448
branch
from
861b5fc
to
7dc3a9f
Compare
jirihnidek
force-pushed
the
jhnidek/1924126
branch
from
2ebe931
to
a7bb9ae
Compare
jirihnidek
changed the title
* BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1924126 * Card ID: ENT-3583 * Fix AWS RHUI repo url, when data for profile are gathered. Replace REGION with value provided in AWS metadata
jirihnidek
force-pushed
the
jhnidek/1924126
branch
from
a7bb9ae
to
91a13e9
Compare
|
How to test this?
|
|
@jirihnidek Is this still in progress? I'll be glad to review/test but don't want to do it before it's ready. If it is ready, please take off the "in progress" label, I'll check back early tomorrow :) |
|
@cnsnyder Sorry for confusing you. It is not in progress. I only forgot to remove this WIP label. |
cnsnyder
reviewed
Jul 15, 2021
cnsnyder
reviewed
Jul 15, 2021
| :return: Yields RHUI repositories | ||
| """ | ||
| for repo_name, repo in base.repos.items(): | ||
| # TODO: we need more reliable mechanism for detection of RHUI repository, because |
There was a problem hiding this comment.
Is this captured somewhere besides this comment?
There was a problem hiding this comment.
We can create card for this task.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace REGION with value provided in AWS metadata