Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subscription-manager dependency to apt-katello-transport #2595

Merged

Conversation

maximiliankolb
Copy link
Contributor

Add a dependency to the subscription-manager package for Debian and
Ubuntu to depend on apt-transport-katello which is necessary to receive content from Foreman.

This PR is a reaction to the following community feedback:

to be able to use the repository on the foreman host the package apt-transport-katello is also needed, could this package be a part of the dependencies when installing python3-subscription-manager?

See Foreman Community Forum

Copy link
Contributor

@ptoscano ptoscano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, just one thing to fix.

contrib/debian/control Outdated Show resolved Hide resolved
Add a dependency to the subscription-manager package for Debian and
Ubuntu to depend on apt-transport-katello.
@maximiliankolb maximiliankolb force-pushed the debian_dependency_apt_transport_katello branch from 2b1d30c to 29cc5a8 Compare April 21, 2021 07:21
Copy link
Contributor

@ptoscano ptoscano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updated patch! LGTM now 👍

@ptoscano ptoscano merged commit cebf49e into candlepin:master Apr 21, 2021
@maximiliankolb maximiliankolb deleted the debian_dependency_apt_transport_katello branch April 21, 2021 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants