2037771: Cockpit registration dialog: enable insights by default #2929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnsnyder
requested review from
a team and
cnsnyder
and removed request for
a team
|
@jirihnidek The changes look good to me, but I'd like the cockpit CI tests to pass before merge. |
cnsnyder
requested changes
Jan 11, 2022
* BZ: https://bugzilla.redhat.com/show_bug.cgi?id=2037771 * Card ID: ENT-4617 * Enable by default checkbox "Connect this system to Red Hat Insights" * It was little bit more tricky than expected. Why? When insights-client is not installed, then auto-attach (enable_content) has to be enabled to be able to install insights-client first. Thus when auto-attach is not enabled, then it is not possible to connect system to Red Hat Insights. * Fixed cockpit integration tests
jirihnidek
force-pushed
the
jhnidek/2037771
branch
from
4e864f3
to
35da66a
Compare
jirihnidek
added a commit
that referenced
this pull request
Feb 7, 2022
* BZ: https://bugzilla.redhat.com/show_bug.cgi?id=2049441 * Card ID: ENT-4723 * Original PR: #2929 * Cherry-picked commit: 35da66a * Enable by default checkbox "Connect this system to Red Hat Insights" * It was little bit more tricky than expected. Why? When insights-client is not installed, then auto-attach (enable_content) has to be enabled to be able to install insights-client first. Thus when auto-attach is not enabled, then it is not possible to connect system to Red Hat Insights. * Fixed cockpit integration tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is not installed, then auto-attach (enable_content) has to be
enabled to be able to install insights-client first. Thus when
auto-attach is not enabled, then it is not possible to connect
system to Red Hat Insights.