2076948: [1.28] Fix issue with race condition in rhsm.service #3199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In addition of a needed rebase, the referenced BZ ought to be 2076948 rather than 2093883. Other than that, same notes as I wrote in #3151: #3151 (review). |
jirihnidek
force-pushed
the
jhnidek/1.28-2093883
branch
from
ade6d3d
to
cd0b97f
Compare
jirihnidek
changed the title
* Backport commit * BZ: https://bugzilla.redhat.com/show_bug.cgi?id=2076948 * Card ID: ENT-5383 * When logging level was changed using D-Bus method SetAll(), then exception was raised and it wasn't possible to change log level. This has happened very rarely. * The race condition was caused probably by this case. When logging level was changed by SetAll() method and it was necessary to re-initialized loggin, then some other process changed rhsm.conf and [logging] section was removed from this file. When iniparse tried to get section logging, then this section wasn't there and it caused exceptions. * Fixed same issue for Set() D-Bus method too. * Original PR: #3151
jirihnidek
force-pushed
the
jhnidek/1.28-2093883
branch
from
cd0b97f
to
33ce84a
Compare
|
Updated the PR and commit as requested. |
Coverage (computed on Fedora latest) •
|
||||||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SetAll(), then exception was raised and it wasn't possible to change log level. This has happened very rarely.Set()D-Bus method too.Backport of PR #3151 to 1.28.