Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1486270: pass no_proxy from config files #193

Merged
merged 1 commit into from Mar 14, 2019
Merged

Conversation

wottop
Copy link
Member

@wottop wottop commented Feb 21, 2019

For testing, the parameter can be placed in either the /etc/virt-who.conf file or the conf file you are using in /etc/virt-who.d

this is the config file I have been using:

[stage-libvirt]
type=libvirt
owner=711497
env=Library
server=qemu:///
#server=10.66.129.67
username=root
password=test
rhsm_proxy_hostname = ktordeur-proxy.usersys.redhat.com
rhsm_proxy_port = 3128
rhsm_proxy_user = proxy
rhsm_proxy_password = proxy
#rhsm_no_proxy = *

@jirihnidek jirihnidek self-assigned this Feb 27, 2019
Copy link
Collaborator

@jirihnidek jirihnidek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The smoke test works as expected. Code is OK too. Please change only one small thing. Commit message should start with 1486270 (not 148670).

@wottop wottop changed the title 148670: pass no_proxy from config files 1486270: pass no_proxy from config files Mar 6, 2019
@jirihnidek jirihnidek merged commit 7baf928 into master Mar 14, 2019
@wottop wottop deleted the wottop/1486270 branch February 24, 2021 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants