Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1748677: Improved timeout for esx #240

Merged
merged 1 commit into from Oct 18, 2019
Merged

1748677: Improved timeout for esx #240

merged 1 commit into from Oct 18, 2019

Conversation

wottop
Copy link
Member

@wottop wottop commented Oct 10, 2019

This makes the call to esx a single request each time with no subsequent polling.

Description of maxWaitSeconds option here:
https://code.vmware.com/docs/4205/vmware-vsphere-web-services-sdk-programming-guide/doc/PG_PropertyCollector.7.7.html

@jirihnidek jirihnidek self-assigned this Oct 14, 2019
Copy link
Contributor

@chris1984 chris1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this on my satellite and it works correctly with the same vmware reproducer @wottop was using

Copy link
Collaborator

@jirihnidek jirihnidek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@jirihnidek jirihnidek merged commit 85b1d32 into master Oct 18, 2019
@jirihnidek jirihnidek deleted the wottop/1748677 branch October 18, 2019 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants