New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade strophe #385
base: dev
Are you sure you want to change the base?
Upgrade strophe #385
Conversation
c1f17d7
to
eb2964a
Compare
f80b20f
to
80e058f
Compare
This appears to be broken due to strophe/strophejs#105 introducing AMD in a way that's not backwards-compatible with non-AMD apps like Candy. I'm not sure if that can be fixed in Strophe, or if Candy needs to move to something like require.js. Thoughts @jcbrand / @mweibel? |
require.js/AMD is not going to happen, it doesn't bring any value (actually quite the opposite, TBH) and becomes soon obsolete due to ES6 (this is my own personal opinion). |
@mweibel You can see the error in the Travis CI test run. The strange thing is that an app appears functional regardless. |
@benlangfeld sorry, late reply. Tested it locally as well and it seems to work also. Wondering why it fails.. could it be that we'd need to add Strophe to the |
I tried that and it didn't make any difference. |
Sorry, I have some issues with running the tests locally.. that's why it takes so long... |
@benlangfeld the test run on saucelabs, can you give me the URL? I didn't find it on https://saucelabs.com/u/candy-chat-ci somehow :( |
No description provided.