-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix added reserved keywords to DotNetNormalizer.cs #59
Conversation
Added string and this to C# reserved keyword list
@badcommandorfilename Thanks for adding these normalization keywords! You will have to update the corresponding |
@canhorn I've updated the tests with basic coverage - I found another one at https://github.com/canhorn/EventHorizon.Blazor.TypeScript.Interop.Generator/blob/05dedfdd7469b2ada3fc210df7d8496f53fe82ef/Tests/EventHorizon.Blazor.TypeScript.Interop.Generator.Tests/GenerateClassStatementStringTests/Constructors/DotNetNormalizedArguments.ts I'm not sure if you prefer to squash commits before merging, so let me know if there are any more changes. |
Codecov Report
@@ Coverage Diff @@
## main #59 +/- ##
=======================================
Coverage 98.85% 98.85%
=======================================
Files 92 92
Lines 4275 4278 +3
Branches 384 384
=======================================
+ Hits 4226 4229 +3
Misses 18 18
Partials 31 31
Continue to review full report at Codecov.
|
@badcommandorfilename Look Good! Also I noticed that the author on some of the commits are under another name. If you squash the commit under your preferred name that should fix the mixed authors. But it is up to you. I am fine to merge this PR either way. Let me know. :) |
d41dab8
to
feaeb4f
Compare
Thanks for spotting the author name @canhorn - I've fixed it up now and I'm happy to merge. This is a very cool project, by the way! Thanks for making something like this. I'm very happy to contribute any more fixes or features as I keep using it. |
Thanks! |
Added string and this to C# reserved keyword list
Hi, I was using this library with tensorflow.js and had to add these keywords to work with the JS names used in that library.
This is pretty low-hanging fruit, so I'm happy to extend this with more of the reserved names in C# if you're looking for help with contributions.