Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Putting a homebrew weapon in magic_items is not resolvable by the content resolver #109

Open
canismarko opened this issue Aug 23, 2021 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@canismarko
Copy link
Owner

No description provided.

@canismarko canismarko added the bug Something isn't working label Aug 23, 2021
@canismarko canismarko self-assigned this Aug 23, 2021
@bw-mutley
Copy link
Contributor

bw-mutley commented Feb 5, 2022

Hi Mark, I was trying to address this issue, but couldn't figure exactly what was the intended behaviour. What I normally do when I add magic items to a character sheet is to list their name (if it is on magic_items.py) or an instance when importing using import_homebrew. Also, when I use homebrewed magic items I include only magic_item as a superclass. Following this procedure I achieved what I needed.

@canismarko
Copy link
Owner Author

Hi, @bw-mutley.

Yeah those methods both work. I think the option I had in mind was importing using import_homebrew then listing the name as a string::

homebrew.py

class MyMagicItem(MagicItem):
....

character.py

import_homebrew("homebrew.py")

magic_items = ["my magic item"]

It tripped me up a few times. This "bug" doesn't really limit what you can do, but does indicate that something isn't working how I think it is when resolving content.

@canismarko canismarko mentioned this issue Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants