Clean up the view and ViewModel signatures #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This splits the signatures for the two options: - String or can-stache.renderer for `view` - Object or constructor function for `ViewModel`
chasenlehara
force-pushed
the
view-model-docs-updates
branch
from
d110723
to
6eae577
Compare
docs/ViewModel.md
Outdated
|
|
||
| For example, every time `<my-tag>` is found, a new instance of `MyTagViewModel` will | ||
| be created: | ||
| For example, every time `<my-tag>` is found, a new [can-define/map/map] instance |
There was a problem hiding this comment.
Maybe this should be [can-define/map/map DefineMap] to match the link above.
phillipskevin
approved these changes
Jun 28, 2018
|
@chasenlehara how do you feel about using ` instead of " for strings? |
|
@justinbmeyer Good, I’ve been using back ticks when it’s multiple lines and sticking to quotes when it’s just a single line. I think a linter (maybe JSHint, not sure?) has trained me not to use back ticks for single lines. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits the signatures for the two options:
viewViewModelview signatures
ViewModel signatures