Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devtools registration happens too early #48

Closed
phillipskevin opened this issue Jun 21, 2018 · 1 comment · Fixed by #49 or #50
Closed

Devtools registration happens too early #48

phillipskevin opened this issue Jun 21, 2018 · 1 comment · Fixed by #49 or #50

Comments

@phillipskevin
Copy link
Contributor

can-debug/can-debug.js

Lines 30 to 39 in a4ff993

if (window.__CANJS_DEVTOOLS__) {
window.__CANJS_DEVTOOLS__.register({
Symbol: canSymbol,
Reflect: canReflect,
queues: canQueues,
getGraph: namespace.debug.getGraph,
formatGraph: namespace.debug.formatGraph,
mergeDeep: mergeDeep
});
}

If this happens synchronously, it happens before devtools injects the script that sets up window.__CANJS_DEVTOOLS__.

This isn't a problem with apps using Steal, but bundled apps or apps using Webpack fail to register with devtools.

@phillipskevin
Copy link
Contributor Author

The fix I put in doesn't actually set the ___CANJS_DEVTOOLS__ global. Going to fix this again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant