Cleanup markdown sample code #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christopherjbaker
changed the title
| @@ -9,8 +9,10 @@ value. | |||
| A constructor function can be provided that is called to convert incoming values set on this property, like: | |||
|
|
|||
| ```js | |||
| prop: { | |||
| Type: Person | |||
| { | |||
There was a problem hiding this comment.
I prefer these examples without the surrounding {} because it shows there might be other properties. But this isn't important.
There was a problem hiding this comment.
It was necessary for the parsers that were updating for let/const and for the linter. There were quite a few like this, over several repositories.
|
I could certainly go through and remove them, though anybody running similar mods in the future will run into this problem again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request was created with Landscaper.
The following code mods were used to create this PR:
Please review this PR carefully as Landscaper does not guarantee any code mod's quality.