Add helper for listening to jQuery events #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chasenlehara
force-pushed
the
add-jquery-events
branch
from
33ac0cb
to
9eace76
Compare
This helper can be used when another module registers $.event.special events and you need to listen to those events with can-dom-events.
chasenlehara
force-pushed
the
add-jquery-events
branch
from
9eace76
to
79e08f0
Compare
chasenlehara
changed the title
justinbmeyer
approved these changes
Apr 2, 2018
helpers/add-jquery-events.js
Outdated
| $(target).off(eventType, handler); | ||
| } | ||
| }; | ||
| var removeEvent = domEvents.addEvent(eventDefinition); |
There was a problem hiding this comment.
might want to check if the event is already in domEvents so there are no errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helper can be used when another module registers $.event.special events and you need to listen to those events with can-dom-events.
Docs:
