Ie11 compat #56
Merged
Ie11 compat #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cherifGsoul
force-pushed
the
ie11-compat
branch
from
a778811
to
635f9cd
Compare
phillipskevin
requested changes
Oct 22, 2018
can-dom-events-test.js
Outdated
| event = new Event(eventType); | ||
| } else { | ||
| var qf = document.querySelector('#qunit-fixture'); | ||
| qf.appendChild(input); |
There was a problem hiding this comment.
Any reason we can't just do this all the time? It seems confusing to do this as part of the feature detection.
There was a problem hiding this comment.
No, but those features are deprecated if they will removed in future browsers versions the tests will break.
There was a problem hiding this comment.
I just mean the appendChild.
phillipskevin
approved these changes
Oct 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix tests for IE11