Fixes the order of .on to onEvent, addEventListener, onKeyValue

canjs · Dec 6, 2018 · aa06912 · aa06912
1 parent 26dd60a
commit aa06912
Show file tree

Hide file tree

Showing 2 changed files with 39 additions and 6 deletions.
diff --git a/map/map-test.js b/map/map-test.js
@@ -402,3 +402,36 @@ test("listenTo and stopListening takes a queueName", function(){
 	CALLS = [];
 
 });
+
+QUnit.test("on goes onEvent, addEventListener, then onKeyValue", function(){
+	var called = [];
+	var fullSet = canReflect.assignSymbols({
+		addEventListener: function(){
+			called.push("addEventListener");
+		}
+	},{
+		"can.onEvent": function(){
+			called.push("onEvent");
+		},
+		'can.onKeyValue': function(){
+			called.push("onKeyValue");
+		}
+	})
+	eventQueue.on.call(fullSet, "event", function(){});
+
+	QUnit.deepEqual(called, ["onEvent"]);
+
+	called = [];
+	var addEvent = canReflect.assignSymbols({
+		addEventListener: function(){
+			called.push("addEventListener");
+		}
+	},{
+		'can.onKeyValue': function(){
+			called.push("onKeyValue");
+		}
+	})
+	eventQueue.on.call(addEvent, "event", function(){});
+
+	QUnit.deepEqual(called, ["addEventListener"]);
+});
diff --git a/map/map.js b/map/map.js
@@ -548,12 +548,12 @@ var props = {
 				domEvents.addEventListener(this, eventName, handler, queue);
 			}
 		} else {
-			if ("addEventListener" in this) {
+			if (this[onEventSymbol]) {
+				this[onEventSymbol](eventName, handler, queue);
+			} else if ("addEventListener" in this) {
 				this.addEventListener(eventName, handler, queue);
 			} else if (this[onKeyValueSymbol]) {
 				canReflect.onKeyValue(this, eventName, handler, queue);
-			} else if (this[onEventSymbol]) {
-				this[onEventSymbol](eventName, handler, queue);
 			} else {
 				if (!eventName && this[onValueSymbol]) {
 					canReflect.onValue(this, handler, queue);
@@ -593,12 +593,12 @@ var props = {
 				domEvents.removeEventListener(this, eventName, handler, queue);
 			}
 		} else {
-			if ("removeEventListener" in this) {
+			if (this[offEventSymbol]) {
+				this[offEventSymbol](eventName, handler, queue);
+			} else if ("removeEventListener" in this) {
 				this.removeEventListener(eventName, handler, queue);
 			} else if (this[offKeyValueSymbol]) {
 				canReflect.offKeyValue(this, eventName, handler, queue);
-			} else if (this[offEventSymbol]) {
-				this[offEventSymbol](eventName, handler, queue);
 			} else {
 				if (!eventName && this[offValueSymbol]) {
 					canReflect.offValue(this, handler, queue);