Use prototype properties as defaults

Closes #91
canjs · Feb 28, 2018 · 4182fae · 4182fae
1 parent ace5d1e
commit 4182fae
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/can-map.js b/can-map.js
@@ -101,10 +101,8 @@ var Map = Construct.extend(
 					if (
 						prop !== "define" &&
 						prop !== "constructor" &&
-						(
-						typeof this.prototype[prop] !== "function" && !canReflect.isValueLike(this.prototype[prop]) ||
-						this.prototype[prop].prototype instanceof Construct
-						)
+						(typeof this.prototype[prop] !== "function" ||
+							this.prototype[prop].prototype instanceof Construct)
 					) {
 						this.defaults[prop] = this.prototype[prop];
 					} else if (canReflect.isObservableLike(this.prototype[prop])) {

diff --git a/can-map_test.js b/can-map_test.js
@@ -492,3 +492,9 @@ QUnit.test("can.isBound", function(){
 	var p = new Person();
 	QUnit.ok(! p[canSymbol.for("can.isBound")](), "not bound");
 });
+
+QUnit.test("prototype properties", function(assert) {
+	var MyMap = Map.extend({ letters: "ABC" });
+	var map = new MyMap();
+	assert.equal(map.attr("letters"), "ABC");
+});