Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only bubble observable children #150

Merged
merged 2 commits into from
Dec 18, 2019

Conversation

bmomberger-bitovi
Copy link
Contributor

This prevents errors being thrown when a CanMap has a child element that is a MapLike but not observable (e.g. "plain" objects with a proto other than Object.prototype).

Fixes #149

@nlundquist
Copy link
Contributor

looks good 👍 nice work

@bmomberger-bitovi bmomberger-bitovi merged commit 0f739ef into master Dec 18, 2019
@bmomberger-bitovi bmomberger-bitovi deleted the only-bubble-observable-children branch December 18, 2019 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when trying to bind to custom types
2 participants