Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid unhandled rejection in Firefox 69 #52

Merged
merged 3 commits into from
Sep 4, 2019
Merged

Avoid unhandled rejection in Firefox 69 #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d05b19
Add .npmrc and remove package-lock.json
Sep 4, 2019
ff3917d
Add Firefox and Safari to Sauce Labs
Sep 4, 2019
605aefe
Avoid unhandled rejection in Firefox 69
Sep 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .npmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
package-lock=false
6 changes: 6 additions & 0 deletions can-ndjson-stream-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,12 @@ conditionalAsyncTest('malformed json', function(assert) {
function errCheck() {
errorCaught = true;
}

// Firefox has a bug where an unhandled rejection is emitted from `new ReadableStream(source)` if `source.start()` rejects.
// See https://bugzilla.mozilla.org/show_bug.cgi?id=1561911 for more info.
// This line should be removed if the Firefox bug above is fixed.
QUnit.onUnhandledRejection = function() {};

var done = assert.async();
var allDone = reader.read().then(function read(result) {
if (result.start) {
Expand Down
Loading