Adds the ability to pass a conversion object like JSON #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from-attribute.js
Outdated
| @@ -24,7 +32,12 @@ function initializeFromAttribute (propertyName, ctr, attributeName) { | |||
| if (ctr[metaSymbol]._attributeChangedCallbackHandler === undefined) { | |||
| ctr[metaSymbol]._attributeChangedCallbackHandler = {}; | |||
| } | |||
| if (attributeName === undefined) { | |||
| if (typeof attributeName === 'object') { | |||
| if (isJSONLike(attributeName)) { | |||
There was a problem hiding this comment.
Can we give a warning when the wrong thing is passed? This can happen in a future PR.
phillipskevin
requested changes
Oct 18, 2019
| } | ||
|
|
||
| attributes.forEach(attribute => { | ||
| const makeFromAttribute = fromAttribute(attribute, JSON); |
There was a problem hiding this comment.
We should make sure that this works correctly if attribute is different from the attribute passed in setAttribute.
|
@phillipskevin I updated the PR as requested, can you review it again, please? |
phillipskevin
approved these changes
Oct 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11
Make it possible to pass a JSON like conversion object:
person: { type: Object, bind: fromAttribute( JSON ) }or:
person: { type: Object, bind: fromAttribute( 'attr-name', JSON ) }