Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ie11 compat #139

Merged
merged 3 commits into from
Oct 22, 2018
Merged

Ie11 compat #139

merged 3 commits into from
Oct 22, 2018

Conversation

cherifGsoul
Copy link
Member

  • Fix the tests for IE11

@matthewp
Copy link
Contributor

👍 lgtm

justinbmeyer
justinbmeyer reviewed Oct 19, 2018
View reviewed changes
can-observation_test.js
// Functions in IE11 dont have name property
// this test is ignored under IE11
if (fn.name) {
assert.equal(arguments[0], "Observation<>", "should use can.getName");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could put expect(3) here

and an

else {
  assert.expect(2)
}

after ..

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@cherifGsoul
Copy link
Member Author

@justinbmeyer This can be merged?

@cherifGsoul cherifGsoul merged commit 02dc2a4 into master Oct 22, 2018
@cherifGsoul cherifGsoul deleted the ie11-compat branch October 22, 2018 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinbmeyer justinbmeyer justinbmeyer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cherifGsoul @matthewp @justinbmeyer