Adding documentation for missing observe methods #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mattchewone
changed the title
|
|
chasenlehara
requested changes
Apr 25, 2019
|
|
||
| ## Events | ||
|
|
||
| `reverse` causes _length_ events to be fired. |
There was a problem hiding this comment.
Yeah, I tested this for all methods. Length get's fired as the items are removed and re-added which is what get's shown in the event.
|
|
||
| ## Events | ||
|
|
||
| `sort` causes _length_ events to be fired. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding documentation to missing array, function and object methods.