Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serializing a Ref creates an empty object in the cache #63

Closed
imaustink opened this issue Oct 11, 2017 · 1 comment · Fixed by #119
Closed

Serializing a Ref creates an empty object in the cache #63

imaustink opened this issue Oct 11, 2017 · 1 comment · Fixed by #119
Assignees
Labels

Comments

@imaustink
Copy link
Collaborator

imaustink commented Oct 11, 2017

When serializing a Ref and providing a MapType to cache with, the cached value is set to an empty object.

Here the value to serialize and a pointer to its cache is provided. Normally, an object would be serialized into a POJO and its properties would be applied to the cache reference. Since in this case, the serialized value is a string, the pointer to its cache is not updated.

To fix this, would it be acceptable to simply check for a string here and set the cache value?

@imaustink imaustink self-assigned this Oct 11, 2017
@imaustink imaustink added the bug label Oct 11, 2017
imaustink added a commit that referenced this issue Oct 13, 2017
imaustink added a commit that referenced this issue Oct 13, 2017
@justinbmeyer justinbmeyer self-assigned this Jun 15, 2018
@justinbmeyer
Copy link
Contributor

ran into this on bitcentive, going to fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants