Improve click handling when pushstate is activated. #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Handle javascript void - Handle target blank - Handle metkey click
justinbmeyer
requested changes
Jan 9, 2017
can-route-pushstate.js
Outdated
| // href has some JS in it, let it run | ||
| if(node.href.trim().indexOf('javascript') === 0) { | ||
| try { | ||
| eval(node.href); |
There was a problem hiding this comment.
if you don't call ev.preventDefault() ... which should happen just by returning, won't it do the browser's default behavior?
Also, you might want to check for javascript: ... less likely someone has a link like javascript.com or something.
chasenlehara
reviewed
Jan 9, 2017
can-route-pushstate.js
Outdated
| } | ||
|
|
||
| // Do not push state if meta key was pressed, mimicing standard browser behavior | ||
| if (e.metaKey) { |
There was a problem hiding this comment.
You might need to check for other modifier keys: https://github.com/canjs/bit-docs-html-canjs/pull/205/files#diff-8efd6c52b5a29c345f4c332394b874d5
|
can-route-pushstate listens on the body ... one idea is to have a plugin "beat" |
|
|
Closing in favor of #77 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #23