Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove can-util as a dependency #454

Merged
merged 1 commit into from
May 21, 2018
Merged

Remove can-util as a dependency #454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions can-stache-bindings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,7 @@ var observeReader = require('can-stache-key');
var ObservationRecorder = require('can-observation-recorder');
var SimpleObservable = require('can-simple-observable');

var assign = require('can-util/js/assign/assign');
var makeArray = require('can-util/js/make-array/make-array');
var each = require('can-util/js/each/each');
var assign = require('can-assign');
var dev = require('can-log/dev/dev');
var domMutate = require('can-dom-mutate');
var domData = require('can-dom-data-state');
Expand Down Expand Up @@ -125,7 +123,7 @@ var behaviors = {
// For each attribute, we start the binding process,
// and save what's returned to be used when the `viewModel` is created,
// the element is removed, or the attribute changes values.
each(makeArray(el.attributes), function(node) {
canReflect.each(el.attributes || [], function(node) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makeArray() isn’t needed because can-reflect.each() can handle a NamedNodeMap.

var dataBinding = makeDataBinding(node, el, {
templateType: tagData.templateType,
scope: tagData.scope,
Expand Down Expand Up @@ -787,7 +785,7 @@ var special = {
vm: true,
on: true
};
each(bindingRules, function(value, key){
canReflect.each(bindingRules, function(value, key){
bindingNames.push(key);
special[key] = true;
});
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
"main": "can-stache-bindings"
},
"dependencies": {
"can-assign": "^1.0.0",
"can-attribute-encoder": "^1.0.0",
"can-attribute-observable": "^0.2.0",
"can-dom-data-state": "^1.0.0",
Expand All @@ -46,7 +47,6 @@
"can-stache": "^4.0.2",
"can-stache-key": "^1.0.0",
"can-symbol": "^1.0.0",
"can-util": "^3.9.0",
"can-view-callbacks": "^4.0.0",
"can-view-live": "^4.0.5",
"can-view-model": "^4.0.0",
Expand Down
7 changes: 3 additions & 4 deletions test/colon/element-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ var domMutate = require('can-dom-mutate');
var domMutateNode = require('can-dom-mutate/node');
var domEvents = require('can-dom-events');

var canEach = require('can-util/js/each/each');
var DefineMap = require("can-define/map/map");

testHelpers.makeTests("can-stache-bindings - colon - element", function(name, doc, enableMO, testIfRealDocument){
Expand Down Expand Up @@ -464,7 +463,7 @@ testHelpers.makeTests("can-stache-bindings - colon - element", function(name, do
}
}
});

var frag = template(viewModel);
domMutateNode.appendChild.call(this.fixture, frag);

Expand Down Expand Up @@ -905,7 +904,7 @@ testHelpers.makeTests("can-stache-bindings - colon - element", function(name, do
equal(inputs[0].value, 'green', "alternate value set");


canEach(ta.getElementsByTagName('option'), function(opt) {
canReflect.each(ta.getElementsByTagName('option'), function(opt) {
if (opt.value === 'red') {
opt.selected = 'selected';
}
Expand All @@ -915,7 +914,7 @@ testHelpers.makeTests("can-stache-bindings - colon - element", function(name, do
domEvents.dispatch(inputs[0], "change");
equal(map.get("color"), "red", "updated from input");

canEach(ta.getElementsByTagName('option'), function(opt) {
canReflect.each(ta.getElementsByTagName('option'), function(opt) {
if (opt.value === 'green') {
opt.selected = 'selected';
}
Expand Down