support nullish contexts for binding with :by #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelzcheng
requested review from
justinbmeyer,
Mattchewone and
phillipskevin
|
Confirmed working for my intended use case via https://jsbin.com/nolobokuyo/1/edit?html,js,output |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves: #510
We want to support event binding to a context which might be undefined through the
:byattribute.The change in functionality will create an observation which watches the context suggested through
:byand rebinds the actual event handler when that context changes. This permits null values, initial or otherwise.Please provide feedback on test cases, if you can think of something that I missed!