Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic function calling warning should not be displayed for helpers.default #15

Closed
phillipskevin opened this issue Nov 22, 2017 · 0 comments · Fixed by #16
Closed
Assignees

Comments

@phillipskevin
Copy link
Contributor

phillipskevin commented Nov 22, 2017

A warning is being (twice) displayed for "helpers" is being called as a function for switch statements:

{{#switch(foo)}}
  {{#case("bar")}}
  {{/case}}

  {{#default()}}
  {{/default}}
{{/switch}}

This happens when looking up helpers.case and helpers.default.

On this line:

return options.proxyMethods !== false ? value.bind(prev) : value;

options.proxyMethods is false and so the function is returned without being called. There should not be a warning in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant