Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance: When writing out an object, check for symbols directly #36

Closed
justinbmeyer opened this issue Jun 19, 2018 · 1 comment
Closed

Performance: When writing out an object, check for symbols directly #36

justinbmeyer opened this issue Jun 19, 2018 · 1 comment

Comments

@justinbmeyer
Copy link
Contributor

The following is costly. We should just check for can.setValue symbol.

} else if(canReflect.isValueLike(propValue) && canReflect.isObservableLike(propValue)){
@justinbmeyer justinbmeyer changed the title When writing out an object, check for symbols directly Performance: When writing out an object, check for symbols directly Jun 19, 2018
justinbmeyer added a commit that referenced this issue Jun 19, 2018
@justinbmeyer
improves performance for #36
7458bfc
@justinbmeyer
Copy link
Contributor Author

closed by: 7458bfc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@justinbmeyer