Deprecate dom/data/core in favor of can-dom-data-state #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's not merge until everything using domdata has been updated. |
phillipskevin
requested changes
Sep 27, 2017
dom/data/core.js
Outdated
| var expando = "can" + new Date(); | ||
| var uuid = 0; | ||
| //!steal-remove-start | ||
| canDev.warn('dom/data/core is deprecated; please use can-dom-data-state instead: https://github.com/canjs/can-dom-data-state'); |
There was a problem hiding this comment.
This is not a public API, so does not need a deprecation notice. You should just delete it.
|
@matthewp you mean everything that is using |
|
@phillipskevin I think I see what you're saying. Since this PR doesn't use it, more than likely nothing is at all. |
|
This PR should cover everything that was previously using |
imaustink
force-pushed
the
deprecate-dom/data/core
branch
from
d49b84b
to
01fd613
Compare
|
@phillipskevin I have removed |
phillipskevin
approved these changes
Sep 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.