Skip to content

Commit

Permalink
Merge pull request #99 from canjs/landscaper/qunit2
Browse files Browse the repository at this point in the history
Landscaper: QUnit2 upgrade
  • Loading branch information
cherifGsoul committed May 27, 2019
2 parents 7e632d5 + 71b3d81 commit a8d0a68
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 20 deletions.
38 changes: 20 additions & 18 deletions can-view-autorender_test.js
Original file line number Diff line number Diff line change
@@ -1,16 +1,17 @@
var QUnit = require('steal-qunit');

var makeIframe = function(src){
var makeIframe = function(assert, src){
var done = assert.async();
var iframe = document.createElement('iframe');
window.removeMyself = function(){
delete window.removeMyself;
delete window.isReady;
delete window.hasError;
document.body.removeChild(iframe);
start();
done();
};
window.hasError = function(error) {
ok(false, error.message || error);
assert.ok(false, error.message || error);
window.removeMyself();
};
document.body.appendChild(iframe);
Expand All @@ -21,27 +22,28 @@ var get = function(map, prop) {
return map.attr ? map.attr(prop) : map.get(prop);
};

var makeBasicTestIframe = function(src){
var makeBasicTestIframe = function(assert, src){
var done = assert.async();
var iframe = document.createElement('iframe');
window.removeMyself = function(){
delete window.removeMyself;
delete window.isReady;
delete window.hasError;
document.body.removeChild(iframe);
start();
done();
};
window.assertOk = function() {
ok.apply(null, arguments);
assert.ok.apply(assert, arguments);
};
window.hasError = function(error) {
ok(false, error.message || error);
assert.ok(false, error.message || error);
window.removeMyself();
};
window.isReady = function(el, scope) {
equal(el.length, 1, "only one my-component");
equal(el[0].innerHTML, "Hello World","template rendered");
assert.equal(el.length, 1, "only one my-component");
assert.equal(el[0].innerHTML, "Hello World","template rendered");

equal(get(scope, "message"), "Hello World", "Scope correctly setup");
assert.equal(get(scope, "message"), "Hello World", "Scope correctly setup");
window.removeMyself();
};
document.body.appendChild(iframe);
Expand All @@ -51,19 +53,19 @@ var makeBasicTestIframe = function(src){
QUnit.module("can-view-autorender");

if (__dirname !== '/') {
QUnit.asyncTest("the basics are able to work for steal", function(){
makeBasicTestIframe(__dirname + "/test/basics.html?" + Math.random());
QUnit.test("the basics are able to work for steal", function(assert) {
makeBasicTestIframe(assert, __dirname + "/test/basics.html?" + Math.random());
});

QUnit.asyncTest("autoload loads a jquery viewmodel fn", function(){
makeIframe(__dirname + "/test/steal-viewmodel.html?" + Math.random());
QUnit.test("autoload loads a jquery viewmodel fn", function(assert) {
makeIframe(assert, __dirname + "/test/steal-viewmodel.html?" + Math.random());
});

QUnit.asyncTest("works with a can-define/map/map", function(){
makeBasicTestIframe(__dirname + "/test/define.html?" + Math.random());
QUnit.test("works with a can-define/map/map", function(assert) {
makeBasicTestIframe(assert, __dirname + "/test/define.html?" + Math.random());
});

QUnit.asyncTest("does not set can-autorender property on sealed ViewModels", function(){
makeBasicTestIframe(__dirname + "/test/define2.html?" + Math.random());
QUnit.test("does not set can-autorender property on sealed ViewModels", function(assert) {
makeBasicTestIframe(assert, __dirname + "/test/define2.html?" + Math.random());
});
}
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
"detect-cyclic-packages": "^1.1.0",
"jshint": "^2.9.1",
"steal": "^1.2.10",
"steal-qunit": "^1.0.1",
"steal-qunit": "^2.0.0",
"steal-tools": "^1.1.2",
"testee": "^0.9.0"
}
Expand Down
2 changes: 1 addition & 1 deletion test/steal-viewmodel.html
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<script>
if( window.parent.QUnit ) {
window.isReady = function(vm) {
window.parent.QUnit.ok( vm, "we got a vm!" );
window.parent.QUnit.assert.ok( vm, "we got a vm!" );
removeMyself();
};
} else {
Expand Down

0 comments on commit a8d0a68

Please sign in to comment.