Merge pull request #162 from canjs/get-paths-booleans

preventing in operator errors if scope._context is not an object
canjs · May 15, 2018 · 16d8a3b · 16d8a3b
2 parents 708381c + 9a70b5c
commit 16d8a3b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/can-view-scope.js b/can-view-scope.js
@@ -447,7 +447,7 @@ assign(Scope.prototype, {
 			// `notContext` and `special` contexts can't be read using `../`
 			var canBeRead = !scope._meta.special &&  !scope._meta.notContext;
 
-			if (canBeRead && canReflect.hasKey(scope._context, normalizedKey)) {
+			if (canBeRead && typeof scope._context === "object" && canReflect.hasKey(scope._context, normalizedKey)) {
 				paths[cur + normalizedKey] = scope._context;
 			}
 

diff --git a/test/scope-test.js b/test/scope-test.js
@@ -1296,6 +1296,7 @@ QUnit.test("scope.getPathsForKey", function() {
 		.add(notContext, { notContext: true })
 		.add(vm, { viewModel: true })
 		.add(special, { special: true })
+		.add(true)
 		.add(nonVm);
 
 	var paths = scope.getPathsForKey("name");
@@ -1304,7 +1305,7 @@ QUnit.test("scope.getPathsForKey", function() {
 		"scope.vm.name": vm,
 		"scope.top.name": top,
 		"name": nonVm,
-		"../../name": vm,
-		"../../../../name": top
+		"../../../name": vm,
+		"../../../../../name": top
 	});
 });