Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removeEventListener throws when passed an undefined handler #161

Closed
phillipskevin opened this issue Feb 6, 2018 · 1 comment · Fixed by #162
Closed

removeEventListener throws when passed an undefined handler #161

phillipskevin opened this issue Feb 6, 2018 · 1 comment · Fixed by #162

Comments

@phillipskevin
Copy link
Contributor

This will throw:

new Zone().run(function(){
  var handler = undefined;
  el.removeEventListener("some-test", handler);
})

because of

can-zone/lib/tasks.js

Line 244 in 5028693

var outHandler = handler[EVENT_HANDLER] || handler;
.
phillipskevin added a commit that referenced this issue Feb 6, 2018
@phillipskevin
adding test for #161
951680a
@phillipskevin
Copy link
Contributor Author

failing test here: 951680a

This was referenced Feb 6, 2018
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

not trying to read EVENT_HANDLER of undefined canjs/can-zone
1 participant
@phillipskevin