Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

not trying to read EVENT_HANDLER of undefined #162

Merged
merged 2 commits into from
Feb 6, 2018
Merged

not trying to read EVENT_HANDLER of undefined #162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
951680a
adding test for #161
phillipskevin Feb 6, 2018
1510c2a
not trying to read EVENT_HANDLER of undefined
phillipskevin Feb 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/tasks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ exports.addEventListener = function(addEventListener, Zone){

exports.removeEventListener = function(removeEventListener, Zone){
return function(eventName, handler, useCapture){
var outHandler = handler[EVENT_HANDLER] || handler;
var outHandler = handler && handler[EVENT_HANDLER] || handler;
return removeEventListener.call(this, eventName, outHandler, useCapture);
};
};
13 changes: 13 additions & 0 deletions test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -883,6 +883,19 @@ if(isBrowser) {
})
.then(done, done);
});

it("removeEventListener doesn't throw when removing a listener that doesn't exist", function(done){
var el = document.createElement("div");

new Zone().run(function(){
var handler = undefined;
el.removeEventListener("some-test", handler);
})
.then(function(data){
assert.ok(true, "it finished");
})
.then(done, done);
});
});

describe("onclick event handler", function() {
Expand Down