New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in component naming #1050

Closed
moschel opened this Issue Jun 4, 2014 · 8 comments

Comments

Projects
None yet
4 participants
@moschel
Contributor

moschel commented Jun 4, 2014

In 2.0.7 you could name a component like tag: 'list' and render it like {{name}}.

As of 2.1.0 any name not containing a dash doesn't work at all in this case. Not sure if this was intentional. Either needs better docs or a bug fix.

@moschel

This comment has been minimized.

Show comment
Hide comment
@moschel

moschel Jun 4, 2014

Contributor

It is another "fails silently" sort of issue, so maybe a warning would be useful too.

Contributor

moschel commented Jun 4, 2014

It is another "fails silently" sort of issue, so maybe a warning would be useful too.

@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Jun 4, 2014

Contributor

I'm not sure what you mean. Render it like what? Is this in stache only?

Sent from my iPhone

On Jun 4, 2014, at 1:13 AM, Brian Moschel notifications@github.com wrote:

In 2.0.7 you could name a component like tag: 'list' and render it like {{name}}.

As of 2.1.0 any name not containing a dash doesn't work at all in this case. Not sure if this was intentional. Either needs better docs or a bug fix.


Reply to this email directly or view it on GitHub.

Contributor

justinbmeyer commented Jun 4, 2014

I'm not sure what you mean. Render it like what? Is this in stache only?

Sent from my iPhone

On Jun 4, 2014, at 1:13 AM, Brian Moschel notifications@github.com wrote:

In 2.0.7 you could name a component like tag: 'list' and render it like {{name}}.

As of 2.1.0 any name not containing a dash doesn't work at all in this case. Not sure if this was intentional. Either needs better docs or a bug fix.


Reply to this email directly or view it on GitHub.

@moschel

This comment has been minimized.

Show comment
Hide comment
@moschel

moschel Jun 4, 2014

Contributor

oops, that got escaped in my text, i meant render it like:

<list>{{name}}</list>
Contributor

moschel commented Jun 4, 2014

oops, that got escaped in my text, i meant render it like:

<list>{{name}}</list>
@moschel

This comment has been minimized.

Show comment
Hide comment
@moschel

moschel Jun 4, 2014

Contributor

Its in mustache and stache actually

Contributor

moschel commented Jun 4, 2014

Its in mustache and stache actually

@moschel

This comment has been minimized.

Show comment
Hide comment
@moschel

moschel Jun 4, 2014

Contributor

@justinbmeyer is this a bug? or expected?

Contributor

moschel commented Jun 4, 2014

@justinbmeyer is this a bug? or expected?

@matthewp

This comment has been minimized.

Show comment
Hide comment
@matthewp

matthewp Jun 4, 2014

Contributor

The custom element spec specifies that custom elements must contain a hyphen, so I think we should enforce that on our end.

Contributor

matthewp commented Jun 4, 2014

The custom element spec specifies that custom elements must contain a hyphen, so I think we should enforce that on our end.

@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Jun 4, 2014

Contributor

This is still a bug. We can enforce it in 3.0.

Sent from my iPhone

On Jun 4, 2014, at 6:55 AM, Matthew Phillips notifications@github.com wrote:

The custom element spec specifies that custom elements must contain a hyphen, so I think we should enforce that on our end.


Reply to this email directly or view it on GitHub.

Contributor

justinbmeyer commented Jun 4, 2014

This is still a bug. We can enforce it in 3.0.

Sent from my iPhone

On Jun 4, 2014, at 6:55 AM, Matthew Phillips notifications@github.com wrote:

The custom element spec specifies that custom elements must contain a hyphen, so I think we should enforce that on our end.


Reply to this email directly or view it on GitHub.

@daffl daffl added this to the 2.1.2 milestone Jun 10, 2014

@daffl

This comment has been minimized.

Show comment
Hide comment
@daffl

daffl Jun 10, 2014

Contributor

Closed via #1053

Contributor

daffl commented Jun 10, 2014

Closed via #1053

@daffl daffl closed this Jun 10, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment