Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in component naming #1050

Closed
moschel opened this issue Jun 4, 2014 · 8 comments
Closed

Regression in component naming #1050

moschel opened this issue Jun 4, 2014 · 8 comments
Milestone

Comments

@moschel
Copy link
Contributor

moschel commented Jun 4, 2014

In 2.0.7 you could name a component like tag: 'list' and render it like {{name}}.

As of 2.1.0 any name not containing a dash doesn't work at all in this case. Not sure if this was intentional. Either needs better docs or a bug fix.

@moschel
Copy link
Contributor Author

moschel commented Jun 4, 2014

It is another "fails silently" sort of issue, so maybe a warning would be useful too.

@justinbmeyer
Copy link
Contributor

I'm not sure what you mean. Render it like what? Is this in stache only?

Sent from my iPhone

On Jun 4, 2014, at 1:13 AM, Brian Moschel notifications@github.com wrote:

In 2.0.7 you could name a component like tag: 'list' and render it like {{name}}.

As of 2.1.0 any name not containing a dash doesn't work at all in this case. Not sure if this was intentional. Either needs better docs or a bug fix.


Reply to this email directly or view it on GitHub.

@moschel
Copy link
Contributor Author

moschel commented Jun 4, 2014

oops, that got escaped in my text, i meant render it like:

<list>{{name}}</list>

@moschel
Copy link
Contributor Author

moschel commented Jun 4, 2014

Its in mustache and stache actually

@moschel
Copy link
Contributor Author

moschel commented Jun 4, 2014

@justinbmeyer is this a bug? or expected?

@matthewp
Copy link
Contributor

matthewp commented Jun 4, 2014

The custom element spec specifies that custom elements must contain a hyphen, so I think we should enforce that on our end.

@justinbmeyer
Copy link
Contributor

This is still a bug. We can enforce it in 3.0.

Sent from my iPhone

On Jun 4, 2014, at 6:55 AM, Matthew Phillips notifications@github.com wrote:

The custom element spec specifies that custom elements must contain a hyphen, so I think we should enforce that on our end.


Reply to this email directly or view it on GitHub.

@daffl daffl added this to the 2.1.2 milestone Jun 10, 2014
@daffl
Copy link
Contributor

daffl commented Jun 10, 2014

Closed via #1053

@daffl daffl closed this as completed Jun 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants