New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can.Control will fail to find $.event.special in a $.noConflict(true) scenario #191

Closed
jeffrose opened this Issue Dec 3, 2012 · 1 comment

Comments

Projects
None yet
2 participants
@jeffrose

jeffrose commented Dec 3, 2012

While I am talking specifically about the AMD build, I assume this is an issue elsewhere. Line 25 of (the AMD build of) can.Control does...

special = can.getObject("$.event.special") || {},

Unfortunately if jQuery has been removed from global scope using $.noConflict(true), the call to can.getObject() will return undefined.

I think a quick fix would be to do this instead...

special = can.getObject("$.event.special", [can]) || {},

@daffl daffl closed this in 21b809b Dec 4, 2012

@daffl

This comment has been minimized.

Show comment
Hide comment
@daffl

daffl Dec 4, 2012

Contributor

Thanks! Acessing can.$ is actually a good fix. Will be part of 1.1.3

Contributor

daffl commented Dec 4, 2012

Thanks! Acessing can.$ is actually a good fix. Will be part of 1.1.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment