Stache promise support doesn't work with ES6 promises

[nlundquist]

https://canjs.com/docs/can.stache.html#section_WorkingwithPromises

The support described here for promises in stache templates appears to only apply to jQuery deferreds. ES6 promises are just treated as any other object in a template.

If this is intended the docs should be updated to reflect it.

A test case to demonstrate: https://github.com/nlundquist/canjs-template-promise-test

Correction: this is resolved by #2247

[matthewp]

Looking at your example, I don't think native Promises have a value property, could this be why?

[justinbmeyer]

That's not why. We add one.

Sent from my iPhone

On Apr 5, 2016, at 6:59 AM, Matthew Phillips notifications@github.com wrote:

Looking at your example, I don't think native Promises have a value property, could this be why?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub

[nlundquist]

I think we should add the same properties to native promises. Or at least document that this support is only for deferreds.

[justinbmeyer]

A+ promises must be working in some fashion, otherwise, all the promises produced by can-connect, which are not native, but A+ (which is close enough) do work.

[justinbmeyer]

Also, we don't need to add anything to native promises, we only have to make sure can.isPromise works for them. My guess is that StealJS's polyfill is making promise instanceof Promise fail.

[justinbmeyer]

This shows native promises working if can.isPromise is fixed: http://jsbin.com/xitezi/1/edit?html,js,output

[nlundquist]

awesome thanks for looking into this