-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bitovi menu is incorrect #2739
Comments
So, add two new menu items? Like:
Looks like http://donejs.com/ links to the 404 as well. Haven't looked into whether or not that would be a separate change or not, but I think it will as I assume this is coming from the respective bit-docs themes. |
Looks like it comes from here: https://github.com/canjs/bit-docs-html-canjs/blob/master/templates/header-right.mustache#L8 Perhaps we can make it a reusable component, to standardize the menu items (and logo size) across websites (DoneJS/CanJS/etc). |
A reusable component would be nice, but not a priority for now. @leoj3n, would you mind submitting a PR to fix the CanJS, DocumentCSS, and DoneJS sites please? [I think all the other ones are ok.] |
The websites are not single page CanJS apps so that couldn't be a can-component. |
The Bitovi menu in 3.0 has "Consulting" which leads to
bitovi.com/consulting
resulting in a 404. Should be "Design" and "Development"While we're at it, the two dots logo is way too big compared to the nav and the CanJS logo. I recommend making it smaller.
The text was updated successfully, but these errors were encountered: