New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download builder should include build version in output #289

Closed
jaredstehler opened this Issue Feb 25, 2013 · 3 comments

Comments

Projects
None yet
4 participants
@jaredstehler

The download builder on canjs.us (and also jquerypp.com) currently outputs a js file which doesn't contain the build version, which would be quite useful. For example, the jquery-ui builder does this (at least as of 1.10)

It also includes the selected components, which is really helpful when upgrading to the latest version of the library.

Here's the output of jquery-ui's builder:

/*! jQuery UI - v1.10.1 - 2013-02-23
* http://jqueryui.com
* Includes: jquery.ui.core.js, jquery.ui.widget.js, jquery.ui.mouse.js, jquery.ui.position.js,     jquery.ui.autocomplete.js, jquery.ui.datepicker.js, jquery.ui.menu.js, jquery.ui.slider.js

@ghost ghost assigned alexisabril Feb 25, 2013

@daffl

This comment has been minimized.

Show comment
Hide comment
@daffl

daffl Feb 25, 2013

Contributor

@alexisabril Can we somehow have the builder run the normal build Grunt tasks but parameterized? That way it would include code formatting and strip out the multiline comments, too.

Targeting for version 1.2 for now.

Contributor

daffl commented Feb 25, 2013

@alexisabril Can we somehow have the builder run the normal build Grunt tasks but parameterized? That way it would include code formatting and strip out the multiline comments, too.

Targeting for version 1.2 for now.

@ghost ghost assigned daffl Apr 9, 2013

@daffl

This comment has been minimized.

Show comment
Hide comment
@daffl

daffl Apr 9, 2013

Contributor

We're working on a new download builder that will include the header, clean up the code and also provide a minify option. Here is an example download how it will look: http://bitbuilder.herokuapp.com/can.custom.js?plugins=can/control&plugins=can/observe

Contributor

daffl commented Apr 9, 2013

We're working on a new download builder that will include the header, clean up the code and also provide a minify option. Here is an example download how it will look: http://bitbuilder.herokuapp.com/can.custom.js?plugins=can/control&plugins=can/observe

@moschel

This comment has been minimized.

Show comment
Hide comment
@moschel

moschel May 26, 2013

Contributor

fixed now

Contributor

moschel commented May 26, 2013

fixed now

@moschel moschel closed this May 26, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment