-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement: can.list.pushAll and can.list.unshiftAll shortcuts #984
Comments
|
From Docs: So it's already in place. |
good |
@isadovskiy Although I find myself doing the apply trick all the time ... I'm wary of having methods on "core" can.List outside of what browsers provide on Array. For example, we added filter, but filter is even in IE9: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/filter. Is there a pushAll on Array? If not, I would rather see this go in a list extension plugin that we've wanted to add since we created CanJS, but have never had the time. If you'd like to work on that, we can add things like this there. |
I think such small things are not reasonable to deliver in plugin as well. It can always be placed on prototype of those classes that need it. But |
Closing for #192. |
Currently it's not convenient to push/unshift arrays to can.List instances.
Can apporpriate shortcuts methods be added to can.List?
And then we just have
The text was updated successfully, but these errors were encountered: