Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is bang syntax "[...]!steal-stache" in README outdated? #28

Open
leoj3n opened this issue Mar 25, 2017 · 1 comment
Open

Is bang syntax "[...]!steal-stache" in README outdated? #28

leoj3n opened this issue Mar 25, 2017 · 1 comment

Comments

@leoj3n
Copy link

leoj3n commented Mar 25, 2017

In this repo's README, Isn't the following bang syntax outdated?

STACHE_MODULE_NAME!steal-stache

It's a bit confusing what that's supposed to be saying, at least to me upon first encounter.

Perhaps STACHE_MODULE_NAME would make more sense as, I think, RELATIVE_FILE_PATH?

Regarding bang syntax, for instance the docs here don't say anything about bang syntax and avoids the ugly STACHE_MODULE_NAME by saying:

To load a CSS module in your JavaScript code, just import it just as you would any other module

@leoj3n
Copy link
Author

leoj3n commented Mar 25, 2017

Ah, well, I guess Steal can do some logic on that "STACHE_MODULE_NAME" so it can be ~/[...].stache or projectname/[...].stache so only sometimes a file path.

I think that could be explained in the README too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant