두가지 수정사항 #17
Merged
두가지 수정사항 #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
cannalee90
commented
Apr 6, 2018
cannalee90
commented
- initialState에서 AccessToken을 초기화(localStorage에서 값을 가져옴) 해준다.
- 한개의 Gist의 여러개의 파일을 추가하는 방식으로 교체
기존에 여러개의 gist를 만드는 것보단 하나의 gist의 파일을 추가하는 방식 각각의 tradeoff가 있는데, 그냥 여러개 gist파일 만들어지는 것도 싫고 해서 이 방식을 택함
Best Practice가 없다는 말에 그냥 initialState에 함께 초기화 함
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.