Skip to content

Add Digest-MD5, NTLM and Kerberos encryption support - #1042

Merged
cannatag merged 5 commits into
cannatag:devfrom
CravateRouge:dev
Mar 19, 2024
Merged

cannatag merged 5 commits into
cannatag:devfrom
CravateRouge:dev

Conversation

@CravateRouge

@CravateRouge CravateRouge commented Jul 8, 2022 •

Copy link
Copy Markdown
Contributor

Add SASL Digest-MD5 encryption for confidentiality protection as described in RFC2831.
Also add NTLM encryption for confidentiality protection as described in MS-NLMP.
And finally add SASL GSSAPI Kerberos encryption support.
Allows you to use LDAP without TLS for sensitive data exchange (e.g AD without LDAPS enabled, which is the default and you want to modify a user password).

@CravateRouge CravateRouge changed the title Add Digest-MD5 encryption support Add Digest-MD5 and NTLM encryption support Jul 15, 2022
@CravateRouge CravateRouge changed the title Add Digest-MD5 and NTLM encryption support Add Digest-MD5, NTLM and Kerberos encryption support Sep 5, 2022
@zorn96

zorn96 commented Sep 13, 2022

Copy link
Copy Markdown
Collaborator

this seems neat. @CravateRouge how have you tested this?

@CravateRouge

Copy link
Copy Markdown
Contributor Author

I made ldap requests on my AD, performing change passwords operation in simple LDAP. I used Wireshark to help me debug this mess.

@ThePirateWhoSmellsOfSunflowers

Copy link
Copy Markdown
Contributor

Very nice PR @CravateRouge, i've tested it and it works like a charm! It allows ldap3 to be used when LDAP Signing is enforced on Domain Controllers.

@cannatag have you planned to merge this one soon?

🌻

@quanah

quanah commented Jul 20, 2023

Copy link
Copy Markdown

DIGEST-MD5 and NTLM are both historic and shouldn't be available at all.

@vruello

vruello commented Aug 2, 2023

Copy link
Copy Markdown

This PR looks great! I have tested the Kerberos encryption and it works like a charm.

Are there any plans to merge it in the near future?

@maretodoric

Copy link
Copy Markdown

This should really be merged, works flawlessly :)

@quanah

quanah commented Oct 11, 2023

Copy link
Copy Markdown

I would disagree, DIGEST-MD5 and NTLM are both historic and should not be used. Kerberos v5 support would be the only bit worth including.

@quanah

quanah commented Oct 11, 2023

Copy link
Copy Markdown

Better to support SCRAM mechanisms

@maretodoric

Copy link
Copy Markdown

Perhaps, but until Windows keeps on deploying it by default, it should still be implemented in clients, as well.
I've deployed AD from AWS and by default ldaps is off and DIGEST-MD5 is supported/enabled.

@Neustradamus

Copy link
Copy Markdown

@cannatag
cannatag merged commit 0bb0b8d into cannatag:dev Mar 19, 2024
@cannatag

Copy link
Copy Markdown
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants