Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Digest-MD5, NTLM and Kerberos encryption support #1042

Merged
merged 5 commits into from Mar 19, 2024

Conversation

CravateRouge
Copy link
Contributor

@CravateRouge CravateRouge commented Jul 8, 2022

Add SASL Digest-MD5 encryption for confidentiality protection as described in RFC2831.
Also add NTLM encryption for confidentiality protection as described in MS-NLMP.
And finally add SASL GSSAPI Kerberos encryption support.
Allows you to use LDAP without TLS for sensitive data exchange (e.g AD without LDAPS enabled, which is the default and you want to modify a user password).

@CravateRouge CravateRouge changed the title Add Digest-MD5 encryption support Add Digest-MD5 and NTLM encryption support Jul 15, 2022
@CravateRouge CravateRouge changed the title Add Digest-MD5 and NTLM encryption support Add Digest-MD5, NTLM and Kerberos encryption support Sep 5, 2022
@zorn96
Copy link
Collaborator

zorn96 commented Sep 13, 2022

this seems neat. @CravateRouge how have you tested this?

@CravateRouge
Copy link
Contributor Author

I made ldap requests on my AD, performing change passwords operation in simple LDAP. I used Wireshark to help me debug this mess.

@ThePirateWhoSmellsOfSunflowers
Copy link
Contributor

Very nice PR @CravateRouge, i've tested it and it works like a charm! It allows ldap3 to be used when LDAP Signing is enforced on Domain Controllers.

@cannatag have you planned to merge this one soon?

🌻

@quanah
Copy link

quanah commented Jul 20, 2023

DIGEST-MD5 and NTLM are both historic and shouldn't be available at all.

@vruello
Copy link

vruello commented Aug 2, 2023

This PR looks great! I have tested the Kerberos encryption and it works like a charm.

Are there any plans to merge it in the near future?

@maretodoric
Copy link

This should really be merged, works flawlessly :)

@quanah
Copy link

quanah commented Oct 11, 2023

I would disagree, DIGEST-MD5 and NTLM are both historic and should not be used. Kerberos v5 support would be the only bit worth including.

@quanah
Copy link

quanah commented Oct 11, 2023

Better to support SCRAM mechanisms

@maretodoric
Copy link

Perhaps, but until Windows keeps on deploying it by default, it should still be implemented in clients, as well.
I've deployed AD from AWS and by default ldaps is off and DIGEST-MD5 is supported/enabled.

@cannatag cannatag merged commit 0bb0b8d into cannatag:dev Mar 19, 2024
@cannatag
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants