-
Notifications
You must be signed in to change notification settings - Fork 281
Add Digest-MD5, NTLM and Kerberos encryption support #1042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
this seems neat. @CravateRouge how have you tested this? |
I made ldap requests on my AD, performing change passwords operation in simple LDAP. I used Wireshark to help me debug this mess. |
Very nice PR @CravateRouge, i've tested it and it works like a charm! It allows ldap3 to be used when LDAP Signing is enforced on Domain Controllers. @cannatag have you planned to merge this one soon? 🌻 |
…ng are enforced on the DC please install cannatag/ldap3#1087 and cannatag/ldap3#1042
DIGEST-MD5 and NTLM are both historic and shouldn't be available at all. |
This PR looks great! I have tested the Kerberos encryption and it works like a charm. Are there any plans to merge it in the near future? |
This should really be merged, works flawlessly :) |
I would disagree, DIGEST-MD5 and NTLM are both historic and should not be used. Kerberos v5 support would be the only bit worth including. |
Better to support SCRAM mechanisms |
Perhaps, but until Windows keeps on deploying it by default, it should still be implemented in clients, as well. |
I have seen this page: https://offsec.almond.consulting/ldap-authentication-in-active-directory-environments.html I do not see SCRAM part, so I have created 2 tickets:
Thanks in advance. |
Thanks! |
Add SASL Digest-MD5 encryption for confidentiality protection as described in RFC2831.
Also add NTLM encryption for confidentiality protection as described in MS-NLMP.
And finally add SASL GSSAPI Kerberos encryption support.
Allows you to use LDAP without TLS for sensitive data exchange (e.g AD without LDAPS enabled, which is the default and you want to modify a user password).