Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move documentation (Closes #116) #118

Merged
merged 3 commits into from Nov 1, 2017

Conversation

mayankagarwal2402
Copy link
Contributor

@mayankagarwal2402 mayankagarwal2402 commented Oct 30, 2017

Closes #116

PR Checklist

Brief description of changes:

Moved "CONTRIBUTING.md" "ISSUE_TEMPLATE.md", and "PULL_REQUEST_TEMPLATE.md" into the .github directory and all other documents(except README.md) to docs as per the requirements.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.483% when pulling cc9fde9 on mayankagarwal2402:move-documentation into 986c80c on cannawen:master.

Copy link
Owner

@cannawen cannawen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

I noticed the PR is marked WIP though, is there any more work to be done or is it ready to be merged in?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.483% when pulling 6c92259 on mayankagarwal2402:move-documentation into 986c80c on cannawen:master.

@mayankagarwal2402
Copy link
Contributor Author

mayankagarwal2402 commented Nov 1, 2017

Just wanted to ensure everything is as per the contribution guidelines.
I've also added myself to the contributors list.
LGTM now. I've unmarked WIP from the PR.

Thanks for the opportunity. 😃

@mayankagarwal2402 mayankagarwal2402 changed the title Move documentation...WIP (Closes #116) Move documentation (Closes #116) Nov 1, 2017
Copy link
Collaborator

@nalinbhardwaj nalinbhardwaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @mayankagarwal2402

@nalinbhardwaj nalinbhardwaj merged commit 15c8d99 into cannawen:master Nov 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move documentation to /docs folder
4 participants