Skip to content
This repository has been archived by the owner on Jun 11, 2020. It is now read-only.

mirroring commit from mu; don't ship production npm deps #18

Merged
merged 1 commit into from Dec 6, 2016
Merged

mirroring commit from mu; don't ship production npm deps #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions Makefile
View file
Open in desktop
Expand Up @@ -62,6 +62,7 @@ $(DIST):
mkdir -p $(DISTDIR)
npm install || (cat npm-debug.log && exit 1)
npm run build
npm install --production || (cat npm-debug.log && exit 1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why, but it seems it doesn't work here - meaning it doesn't remove dev dependencies.

I checked it out in MU and it seems to work there (calling npm install followed by npm install --production removes unnecessary dependencies). But in here it seems to do nothing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I think I found why it's not working. We lack npm-shrinkwrap.json.

It seems that only with npm-shrinkwrap.json being present npm install followed by npm install --production actually removes dev dependencies.

touch $@

$(PAYLOAD): $(CHARM) $(DIST) version-info build-exclude.txt $(SRC) $(SRC)/* $(SRC_PREQS)
Expand Down